fix(template_mailer): never hand templated email to itself (PPT-2816) - #635
Merged
Merged
Conversation
The Template Mailer picked the module at index 1 of the system's Mailer implementers. That list comes from a redis hash with no defined order, and after a system edit on HIO UAT the order changed so that index 1 was the Template Mailer itself: every templated send recursed until core was OOM killed, and the visitor mailer's sends went to the Calendar module. The mailer is now the next Mailer after this module in the system, and never this module, with the first other Mailer as the fallback. PPT-2816
camreeves
marked this pull request as ready for review
September 28, 2026 06:50
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Template Mailer chose
system.implementing(Interface::Mailer)[1]as the mailer to hand rendered email to. That index is a position in a redis hash with no defined order. On HIO UAT on 24 Sep a system edit rewrote the hash with the Calendar module ahead of the mailers, so index 1 became the Template Mailer itself: a directsend_templaterecursed until core-0 was OOM killed, and the visitor mailer's sends (index 0) went to the Calendar module, which has no templates and logged a warning nobody sees.The mailer is now the next Mailer after this module in the system (
Mailer_2forMailer_1), never this module, with the first other Mailer as the fallback. The spec's two mock mailers now record onMailer_1, since the driver under test is not in the spec runner's module map.Related
implementingreturns modules in the system's module order instead of redis hash order, so index 0 is stable for the other mailer users.PPT-2816, root cause on the ticket.