feat(groups): configure default permissions and AD group sync (PPT-2819) - #311
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Groups now have
default_permissionsandad_group_mappings(PlaceOS/models ba1c194, c0c235e). Users added to a group without permissions get the default. Users in a mapped AD group are added to the group automatically. Backoffice cannot set either field.Jira: PPT-2819. The recording is on the Jira issue. This PR covers backoffice only. Signage manager is a separate change.
Fix
/api/staff/v1/groups. Otherwise, you type the AD group ID and name./api/staff/v1/tenants. Only admins can read that list, so for other users the form tries the group search instead.permissions, so the backend applies the default.@placeos/ts-clientto 6.7.0. That release addsPlaceGroup.default_permissions,PlaceGroup.ad_group_mappingsandPlaceGroupUser.auto_assigned(PlaceOS/ts-client 0ac9150).Checks
bun run test:ci: 82 files, 953 tests pass. New tests cover mapping ID normalisation, add/remove/edit in the AD group field, tenant detection with the non-admin fallback, and the bulk add default.bun run lint,tsc,bun run build: pass.Not verified on a live Office 365 tenant: the non-admin check sends
/api/staff/v1/groups?q=with an empty query.Made by Claude Opus 5.5 (1M context) in Claude Code (T3 Code).
🤖 Generated with Claude Code