Skip to content

Add Brazilian Portuguese translation #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdaLovelace2077 wants to merge 7 commits into
base: main
Choose a base branch
from
+296 −2
Open

Add Brazilian Portuguese translation #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b84e37b
Create strings.xml
AdaLovelace2077 Nov 11, 2026
ea502a6
Delete app/src/main/res/rvalues-pt-rBR/strings.xml
AdaLovelace2077 Nov 11, 2026
9914c5e
Create strings.xml
AdaLovelace2077 Nov 11, 2026
54bceb3
Add Portuguese translations for app strings
AdaLovelace2077 Nov 11, 2026
f3a8adb
Add Brazilian Portuguese to locale configuration
AdaLovelace2077 Nov 11, 2026
dc64593
Update localeFilters to include Brazilian Portuguese
AdaLovelace2077 Nov 11, 2026
8163007
Add Portuguese (Brazil) language support
AdaLovelace2077 Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ android {
localeFilters.addAll(
listOf(
"en", "ar", "de", "es", "fr", "in",
"it", "ko", "nb", "ru", "tr", "zh-rCN", "vi"
"it", "ko", "nb", "pt-rBR", "ru", "tr", "zh-rCN", "vi"
)
)
}
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/lostf1sh/pixelplayeross/data/preferences/AppLanguage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ enum class AppLanguage(val tag: String, @StringRes val labelRes: Int) {
RUSSIAN("ru", R.string.setcat_language_russian),
TURKISH("tr", R.string.setcat_language_turkish),
ZH_RCN("zh-CN", R.string.language_zh_rCN),
VIETNAMESE("vi", R.string.setcat_language_vietnamese);
VIETNAMESE("vi", R.string.setcat_language_vietnamese),
PORTUGUESE_BR("pt-BR", R.string.setcat_language_portuguese_br);

@greptile-apps greptile-apps Bot Nov 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Missing label breaks compilation

PORTUGUESE_BR references R.string.setcat_language_portuguese_br, but no resource defines that name. The generated R.string has no matching field, so Kotlin compilation fails. Add the label to values/strings_settings.xml so it is available in every language.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: app/src/main/java/com/lostf1sh/pixelplayeross/data/preferences/AppLanguage.kt
Line: 22

Comment:
**Missing label breaks compilation**

`PORTUGUESE_BR` references `R.string.setcat_language_portuguese_br`, but no resource defines that name. The generated `R.string` has no matching field, so Kotlin compilation fails. Add the label to `values/strings_settings.xml` so it is available in every language.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

@greptile-apps greptile-apps Bot Nov 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Language tests now fail

Adding PORTUGUESE_BR breaks two existing checks in AppLanguageTest:

  • One still expects normalize("pt-BR") to return the system language.
  • The language-options test uses a labels map without Portuguese, so its mock throws when asked for the new label.

Update both checks alongside the enum. Otherwise the unit tests still fail after the missing resource is added.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: app/src/main/java/com/lostf1sh/pixelplayeross/data/preferences/AppLanguage.kt
Line: 22

Comment:
**Language tests now fail**

Adding `PORTUGUESE_BR` breaks two existing checks in `AppLanguageTest`:
- One still expects `normalize("pt-BR")` to return the system language.
- The language-options test uses a `labels` map without Portuguese, so its mock throws when asked for the new label.

Update both checks alongside the enum. Otherwise the unit tests still fail after the missing resource is added.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex


companion object {
val supportedLanguageTags: Set<String> = entries.map { it.tag }.toSet()
Expand Down
Loading