Pin ruff at 0.16.4 to match what the VS Code extension bundles - #68
Merged
Conversation
Ruff 0.16 lints pyproject.toml itself, and the VS Code extension syncs config files to the language server. A pre-0.16 binary parses those TOML documents as Python source and paints phantom invalid-syntax diagnostics on lines like requires-python, so the editor disagreed with the CLI. This repo matters more than its size suggests: it is the starter template every new Pipelex project is cloned from, so the stale 0.14.13 pin was propagating into fresh checkouts. The upgrade produced no lint findings. It did reformat one Python code block inside a wip/ Markdown doc, which is new 0.16 formatter behaviour (Ruff now formats Python embedded in Markdown) and would otherwise fail merge-check-ruff-format in CI. agent-check and agent-test both pass. Also drops the ruff.configuration entry from .vscode/settings.json. That setting takes a path to a config file, not a CLI flag, so the value "--config=pyproject.toml" never resolved and only worked by falling back to Ruff's normal filesystem discovery. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Confidence Score: 5/5The PR appears safe to merge, with no actionable changed-code defects identified. The Ruff pin and lockfile agree, supported development platforms have matching artifacts, existing Ruff commands remain compatible, and removing the invalid editor setting preserves normal root configuration discovery. Reviews (1): Last reviewed commit: "Pin ruff at 0.16.4 to match what the VS ..." | Re-trigger Greptile |
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the workspace-wide ruff 0.16.4 rollout (
wip/updates/ruff-0.16.4-workspace-rollout-20260814.md). This is repo 2 of the scoped batch of seven, after cocode#83.Why
Ruff 0.16 lints
pyproject.tomlitself, and the Ruff VS Code extension syncs config files to the language server. A pre-0.16 binary parses those TOML documents as Python source and paints phantomRuff(invalid-syntax)diagnostics on lines likerequires-python— read asrequires - python, an invalid assignment target. The extension runs whatever binary it finds, repo venv first, so the venv pin is what has to move.This repo is worth doing early despite its size: it is the starter template new projects are cloned from, so the stale pin was propagating into fresh checkouts rather than staying put.
The installed extension (
charliermarsh.ruff-2026.74.0) bundles ruff 0.16.4, hence that version. Keeping the pin exact rather than a floor is what stops the editor and the CLI from drifting apart again.What changed
pyproject.toml:ruff==0.14.13→ruff==0.16.4, plus the matchinguv.lockupdate. This was the repo's only ruff pin site.wip/mode-split-clis.md: one Python code block reformatted. This is new 0.16 formatter behaviour — Ruff now formats Python embedded in Markdown — andmerge-check-ruff-formatin CI would fail without it. The change is blank lines around a nested function definition in a doc sample; no prose and no shipped code is touched..vscode/settings.json: dropped"ruff.configuration": "--config=pyproject.toml". That setting takes a path to a config file, not a CLI flag, so the value never resolved — it only ever worked by falling back to Ruff's normal filesystem discovery, which finds the samepyproject.tomlanyway.Fallout: none in shipped code
Nothing shipped changes — ruff is a dev dependency. The upgrade produced zero lint findings, as the rollout plan predicted for this repo: the ruff config uses a narrow
selectlist withoutpreview, so none of the new preview rules or thenoqa→ruff: ignore[...]migration that dominated thepipelexsweep applies. The generatedpiper/generatedtree is already excluded from ruff, so thecodegen.lockdrift check is unaffected.Verification
make agent-check(fix-unused-imports, ruff + plxt format and lint, pyright, mypy) andmake agent-testboth pass.🤖 Generated with Claude Code