You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the starter project for a new Pipelex release. The main changes are:
Bumps the project version to 0.9.0.
Updates the Pipelex dependency and lockfile to 0.32.0.
Migrates the dry-run integration test to BundleValidator().acquire_and_validate().
Adds a Claude release workflow skill.
Adjusts Pyright virtualenv and exclude settings.
Confidence Score: 4/5
This looks mostly safe to merge, but a couple of release and test-coverage fixes would help.
The dependency and lockfile agree on Pipelex 0.32.0.
The changelog records the wrong Pipelex version for the release.
The migrated validation test remains excluded from the GitHub test target.
CHANGELOG.md and tests/integration/test_fundamentals.py.
Important Files Changed
Filename
Overview
CHANGELOG.md
Adds the v0.9.0 release entry, but the Pipelex version in the note does not match the dependency update.
tests/integration/test_fundamentals.py
Migrates the dry-run validation test to the new BundleValidator API while keeping it excluded from the main CI test target.
pyproject.toml
Bumps project and dependency versions and updates Pyright configuration.
Comments Outside Diff (1)
tests/integration/test_fundamentals.py, line 7 (link)
Run validation in CI This class still has @pytest.mark.gha_disabled, while make gha-tests excludes gha_disabled tests. That means the migrated BundleValidator().acquire_and_validate() path is skipped by the PR test workflow, so a broken bundle validation path can merge without being exercised. If this test is meant to cover the dependency migration, it needs to run in the GitHub test job or the workflow needs to invoke the disabled-test target separately.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/integration/test_fundamentals.py
Line: 7
Comment:
**Run validation in CI** This class still has `@pytest.mark.gha_disabled`, while `make gha-tests` excludes `gha_disabled` tests. That means the migrated `BundleValidator().acquire_and_validate()` path is skipped by the PR test workflow, so a broken bundle validation path can merge without being exercised. If this test is meant to cover the dependency migration, it needs to run in the GitHub test job or the workflow needs to invoke the disabled-test target separately.
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---### Issue 1 of 2
CHANGELOG.md:5
**Correct dependency version** The release entry says this bumps `pipelex` to `v0.31.0`, but `pyproject.toml` now requires `>=0.32.0` and the lockfile resolves `pipelex` to `0.32.0`. The `v0.9.0` release notes will point users to the wrong dependency version and changelog range.
```suggestion- Bump `pipelex` to `v0.32.0`: See `Pipelex` changelog [here](https://docs.pipelex.com/changelog/)```### Issue 2 of 2
tests/integration/test_fundamentals.py:7
**Run validation in CI** This class still has `@pytest.mark.gha_disabled`, while `make gha-tests` excludes `gha_disabled` tests. That means the migrated `BundleValidator().acquire_and_validate()` path is skipped by the PR test workflow, so a broken bundle validation path can merge without being exercised. If this test is meant to cover the dependency migration, it needs to run in the GitHub test job or the workflow needs to invoke the disabled-test target separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.