Skip to content

Pipelex dependency update - #53

Merged
lchoquel merged 3 commits into
mainfrom
release/v0.9.0
Jun 9, 2026
Merged

lchoquel merged 3 commits into
mainfrom
release/v0.9.0

Conversation

@lchoquel

@lchoquel lchoquel commented Jun 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@lchoquel
lchoquel requested a review from thomashebrard June 9, 2026 11:23
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the starter project for a new Pipelex release. The main changes are:

  • Bumps the project version to 0.9.0.
  • Updates the Pipelex dependency and lockfile to 0.32.0.
  • Migrates the dry-run integration test to BundleValidator().acquire_and_validate().
  • Adds a Claude release workflow skill.
  • Adjusts Pyright virtualenv and exclude settings.

Confidence Score: 4/5

This looks mostly safe to merge, but a couple of release and test-coverage fixes would help.

  • The dependency and lockfile agree on Pipelex 0.32.0.
  • The changelog records the wrong Pipelex version for the release.
  • The migrated validation test remains excluded from the GitHub test target.

CHANGELOG.md and tests/integration/test_fundamentals.py.

Important Files Changed

Filename Overview
CHANGELOG.md Adds the v0.9.0 release entry, but the Pipelex version in the note does not match the dependency update.
tests/integration/test_fundamentals.py Migrates the dry-run validation test to the new BundleValidator API while keeping it excluded from the main CI test target.
pyproject.toml Bumps project and dependency versions and updates Pyright configuration.

Comments Outside Diff (1)

  1. tests/integration/test_fundamentals.py, line 7 (link)

    P2 Run validation in CI This class still has @pytest.mark.gha_disabled, while make gha-tests excludes gha_disabled tests. That means the migrated BundleValidator().acquire_and_validate() path is skipped by the PR test workflow, so a broken bundle validation path can merge without being exercised. If this test is meant to cover the dependency migration, it needs to run in the GitHub test job or the workflow needs to invoke the disabled-test target separately.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: tests/integration/test_fundamentals.py
    Line: 7
    
    Comment:
    **Run validation in CI** This class still has `@pytest.mark.gha_disabled`, while `make gha-tests` excludes `gha_disabled` tests. That means the migrated `BundleValidator().acquire_and_validate()` path is skipped by the PR test workflow, so a broken bundle validation path can merge without being exercised. If this test is meant to cover the dependency migration, it needs to run in the GitHub test job or the workflow needs to invoke the disabled-test target separately.
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
CHANGELOG.md:5
**Correct dependency version** The release entry says this bumps `pipelex` to `v0.31.0`, but `pyproject.toml` now requires `>=0.32.0` and the lockfile resolves `pipelex` to `0.32.0`. The `v0.9.0` release notes will point users to the wrong dependency version and changelog range.

```suggestion
- Bump `pipelex` to `v0.32.0`: See `Pipelex` changelog [here](https://docs.pipelex.com/changelog/)
```

### Issue 2 of 2
tests/integration/test_fundamentals.py:7
**Run validation in CI** This class still has `@pytest.mark.gha_disabled`, while `make gha-tests` excludes `gha_disabled` tests. That means the migrated `BundleValidator().acquire_and_validate()` path is skipped by the PR test workflow, so a broken bundle validation path can merge without being exercised. If this test is meant to cover the dependency migration, it needs to run in the GitHub test job or the workflow needs to invoke the disabled-test target separately.

Reviews (1): Last reviewed commit: "Pipelex dependency update" | Re-trigger Greptile

Comment thread CHANGELOG.md Outdated
@lchoquel
lchoquel merged commit 0d74d18 into main Jun 9, 2026
16 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
@lchoquel
lchoquel deleted the release/v0.9.0 branch June 9, 2026 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant