Fixed a bug in PR #2342 where Survivor.Side# was overridden - #2397
Open
Fly-Star-him wants to merge 7 commits into
Open
Fixed a bug in PR #2342 where Survivor.Side# was overridden#2397Fly-Star-him wants to merge 7 commits into
#2342 where Survivor.Side# was overridden#2397Fly-Star-him wants to merge 7 commits into
Conversation
Fly-Star-him
changed the title
PR #2342 where Survivor.Side# was overridden#2342 where Survivor.Side# was overridden
|
To Chinese users:
|
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
DeathFishAtEase
added
Skip Changelog
Coronia
approved these changes
Sep 9, 2026
[Country] sections are parsed before the [InfantryTypes] table is registered, so a strict Find for or any infantry id fails there and Crew stays unset. Use InfantryTypeClass::FindOrAllocate like the vanilla veteran list readers (0x524CB0); the type table gets filled in afterwards by Read_InfantryTypes.
DeathFishAtEase
added
the
Will be merged in 24h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in PR #2342.
In fact, TechnoType has micro-level custom settings such as
Survivor.Side0,Survivor.Side1, and so on; theCrewspecified by the country should not override them.