Recursive conversion for spawners - #2396
Open
FS-21 wants to merge 3 commits into
Open
Conversation
…ed spawns - Convert existing spawned units in-flight and docked instead of destroying them when spawner converts to a type with different Spawns. - Preserve SpawnManagerClass and update SpawnType/rates smoothly across conversions. - Initialize IsSpawnMissile based on MissileSpawn. - Allow docked and newly regenerated spawns to launch when spawner is actively attacking an existing target.
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Contributor
Contributor
Contributor
|
one more thing, if a spawn jet with Strafing weapon converts into another spawn jet without it, it might still perform a Strafing attack with the new spawn jet's weapon. This is more like a problem of conversion itself tho, but it would need to be more compatible to cooperate with this feature |
Contributor
|
Suggestion: Ignore all MissileSpawn. Do nothing when the from or to is MissileSpawn. |
Contributor
|
Perhaps you could add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Currently, when a spawner is converted into a type with a different Spawns, all spawned aircraft are destroyed and the manager is recreated from scratch.
Now spawned aircrafts are preserved across conversions and recursively converts existing spawned units (both in-flight and docked) to the new Spawns type instead of killing them.
In addition, if the spawner is actively attacking a target, newly ready or regenerated spawns will now automatically launch towards it instead of staying docked in cooldown.