Skip to content

Customizable damage divider for default AnimList picker - #2394

Open
Fryone wants to merge 3 commits into
Phobos-developers:developfrom
Fryone:fryone/animlist_divider
Open

Customizable damage divider for default AnimList picker#2394
Fryone wants to merge 3 commits into
Phobos-developers:developfrom
Fryone:fryone/animlist_divider

Conversation

@Fryone

@Fryone Fryone commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

'AnimList.DamageDivider' per warhead instead of hardcoded '25'.

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

'AnimList.DamageDivider' per warhead instead of hardcoded '25'.
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@NetsuNegi

Copy link
Copy Markdown
Contributor

have you test it?

@NetsuNegi NetsuNegi added Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable labels Sep 8, 2026
@Fryone

Fryone commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

I did put other number (like hardcoded other value) and tested it, it was working, then I replaced with variable. So, partially

proper code
@Fryone

Fryone commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Should there be same for SplashLists and Crit_AnimLists?

@NetsuNegi

Copy link
Copy Markdown
Contributor

Should there be same for SplashLists and Crit_AnimLists?

I think so, but attention that divider of SplashList in vanilla is 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants