Money switch building active animation by dh381-1 · Pull Request #2380 · Phobos-developers/Phobos

dh381-1 · 2026-08-31T08:55:07Z

What kind of change is this?

New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

Now you can use ActiveAnim.MoneyAmount, ActiveAnimTwo.MoneyAmount, ActiveAnimThree.MoneyAmount, ActiveAnimFour.MoneyAmount to switch active animation of building.
When funds are greater than ActiveAnimFour.MoneyAmount, ActiveAnimFour is played; when funds are greater than ActiveAnimThree.MoneyAmount but less than ActiveAnimFour.MoneyAmount, ActiveAnimThree is played, and so on. If the corresponding animation does not exist, no switch will occur.

In rulesmd.ini:

[SOMEBUILDING]                   ; BuildingType
ActiveAnim.MoneyAmount=1000      ; integar
ActiveAnimTwo.MoneyAmount=2000   ; integar
ActiveAnimThree.MoneyAmount=3000 ; integar
ActiveAnimFour.MoneyAmount=4000  ; integar

All four configuration entries default to `-1`. The feature will only be enabled when all entries have been configured.

github-actions · 2026-08-31T23:31:22Z

Nightly build for this pull request:

compiled-dll-9b5751bd40eda5038015aed74b7405f9dbdb484a.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

NetsuNegi · 2026-08-31T23:31:04Z

+       	   && pTypeExt->ActiveAnimThree_MoneyAmount != -1
+	       && pTypeExt->ActiveAnimFour_MoneyAmount != -1)
+		{
+			if(auto pBuildingExt = BuildingExt::Fetch(pThis))


NetsuNegi · 2026-08-31T23:31:10Z

+       	   && pTypeExt->ActiveAnimThree_MoneyAmount != -1
+	       && pTypeExt->ActiveAnimFour_MoneyAmount != -1)
+		{
+			if(auto pBuildingExt = BuildingExt::Fetch(pThis))


NetsuNegi · 2026-08-31T23:32:49Z

+			{
+				int Grade = pBuildingExt->MoneyGrade;
+				R->EAX(Grade);
+				__asm { cmp eax, 3 }


You should manually compare and jump to the corresponding address instead of directly writing the assembly.
你应当手动检查并跳转到对应地址，而不是直接写汇编。

NetsuNegi · 2026-08-31T23:34:15Z

+	__asm 
+	{
+        cmp eax, 3           
+        mov [esi + 0x6F0], eax 


Same here.
这里也是。

phoboscn-bot · 2026-09-01T00:17:46Z

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/755/1

TaranDahl · 2026-09-07T07:50:39Z

+	if(pTypeExt->ActiveAnim_MoneyAmount != -1
+	   && pTypeExt->ActiveAnimTwo_MoneyAmount != -1
+       && pTypeExt->ActiveAnimThree_MoneyAmount != -1
+	   && pTypeExt->ActiveAnimFour_MoneyAmount != -1)


Caching these in BuildingTypeExt would be better.

- only AE that's been applied through the TechnoType tags should be considered as self owned - other scenario (e.g. applied through warhead from itself) shouldn't be handled in the same way - if simply checking whether the source is equal to the target, some process will be wrong

- SourceHouse of damage arg is likely to be null in some cases (e.g. AmbientDamage), resulting in wrong damage calculation - use the same method as Ares now: try to use Attacker's owner as source house first, and fallback to SourceHouse if not exists

…ectory to ignore settings such as `BounceTimes` (Phobos-developers#2383)  ## What kind of change is this?  - [ ] **New feature, vanilla bugfix or enhancement of a released feature** - changelog, docs and credits entries are needed. - [ ] **Improvement to a new (unreleased) feature** - docs and credits entries are needed; no changelog entry (`Skip Changelog`). - [ ] **Bugfix to a new (unreleased) feature** - credits entry is needed; no changelog or docs entries (`Skip Changelog`, `Skip Docs`). - [X] **Bugfix to an old (released) feature** - changelog and credits entries are needed; no docs entry (`Skip Docs`). - [ ] **Completely minor change (e.g. a typo fix)** - no entries are needed (`Skip Changelog`, `Skip Docs`, `Skip Credits`). ## Description In vanilla, `Ranged=true` runs a check that, once the fuse timer has expired, snaps the bullet onto the target coordinates and detonates it as soon as the projectile comes within 64 leptons of them. This check runs after the trajectory system has decided the projectile should keep flying (the trajectory `BulletClass_AI_Trajectories` hook at 0x4666F7) and bypasses all of the trajectory's detonation logic - including the shared `DetonationDistance` / `TargetSnapDistance` handling and the Parabola bouncing mechanism.

## What kind of change is this?  - [X] **New feature, vanilla bugfix or enhancement of a released feature** - changelog, docs and credits entries are needed. - [ ] **Improvement to a new (unreleased) feature** - docs and credits entries are needed; no changelog entry (`Skip Changelog`). - [ ] **Bugfix to a new (unreleased) feature** - credits entry is needed; no changelog or docs entries (`Skip Changelog`, `Skip Docs`). - [ ] **Bugfix to an old (released) feature** - changelog and credits entries are needed; no docs entry (`Skip Docs`). - [ ] **Completely minor change (e.g. a typo fix)** - no entries are needed (`Skip Changelog`, `Skip Docs`, `Skip Credits`). ## Description In vanilla, the number of game frames each animation frame of the infantry sequence stays (i.e., its playback rate) is hardcoded. Now it can be customized for each sequence in each infantry's sequence section. - `<Sequence>Rate` defines the number of game logic frames that 1 animation frame stays; 0 means still, for example, the `Ready` and `Guard` sequences in vanilla are still. - `<Sequence>Normalized` defines whether the playback rate is affected by game speed, for example, the `Idle1`, `Idle2`, `WetIdle1`, `WetIdle2`, `Hover`, and `Cheer` sequences in vanilla are affected by game speed. ```{note} The effective rate of a normalized sequence is `rate` adjusted by the game speed: - `rate < 5`: from the table below (`rate` row, `GameSpeed` column). - `rate >= 5`: `rate * 8 / (GameSpeed + 1)`. | Rate \ GameSpeed | 0 | 1 | 2 | 3 | 4 | 5 | 6 | | ---------------- | - | - | - | - | - | - | - | | 1 | 2 | 2 | 1 | 1 | 1 | 1 | 1 | | 2 | 3 | 3 | 3 | 2 | 2 | 2 | 1 | | 3 | 5 | 4 | 4 | 3 | 3 | 2 | 2 | | 4 | 7 | 6 | 5 | 4 | 4 | 4 | 3 | `GameSpeed` goes from `0` (fastest) to `6` (slowest). ``` In `rulesmd.ini`: ```ini [AudioVisual] Sequence.<Sequence>.DefaultRate=0 ; integer Sequence.<Sequence>.DefaultNormalized=no ; boolean ``` ```{dropdown} Default value table | Name | DefaultRate | Normalized | |-----------------|-------------|------------| | Ready | 0 | false | | Guard | 0 | false | | Prone | 6 | false | | Walk | 3 | false | | FireUp | 1 | false | | Down | 1 | false | | Crawl | 1 | false | | Up | 1 | false | | FireProne | 1 | false | | Idle1 | 3 | true | | Idle2 | 3 | true | | Die1 | 1 | false | | Die2 | 1 | false | | Die3 | 1 | false | | Die4 | 1 | false | | Die5 | 1 | false | | Tread | 3 | false | | Swim | 1 | false | | WetIdle1 | 3 | true | | WetIdle2 | 3 | true | | WetDie1 | 1 | false | | WetDie2 | 1 | false | | WetAttack | 1 | false | | Hover | 2 | true | | Fly | 1 | false | | Tumble | 1 | false | | FireFly | 1 | false | | Deploy | 1 | false | | Deployed | 1 | false | | DeployedFire | 1 | false | | DeployedIdle | 1 | false | | Undeploy | 1 | false | | Cheer | 3 | true | | Paradrop | 1 | false | | AirDeathStart | 3 | false | | AirDeathFalling | 1 | false | | AirDeathFinish | 3 | false | | Panic | 4 | false | | Shovel | 6 | false | | Carry | 3 | false | | SecondaryFire | 1 | false | | SecondaryProne | 1 | false | ``` In `artmd.ini`: ```ini [SEQUENCE] ; Sequence <Sequence>Rate= ; integer, defaults to [AudioVisual] -> Sequence.<Sequence>.DefaultRate <Sequence>Normalized= ; boolean, defaults to [AudioVisual] -> Sequence.<Sequence>.DefaultNormalized ``` > [!Tip] > The naming of each infantry flag is aligned with `[Sequence] -> <Sequence>Sounds= (List of sound entries)` (Vanilla flag. It is concatenated by `<Sequence>` and the suffix `Sounds`, so the full string is not stored in `gamemd.exe`, see `0x523FC4`.).

…developers#2366)

TaranDahl · 2026-09-09T08:11:13Z

Don't know why I'm being requested to review again.
I already approved it. Also, you haven't made the minor changes I suggested.

dh381-1 added 3 commits August 31, 2026 15:59

initial

bee9de1

update doc

01787f5

update doc

721c86c

NetsuNegi reviewed Aug 31, 2026

View reviewed changes

Comment thread docs/New-or-Enhanced-Logics.md Outdated

NetsuNegi reviewed Aug 31, 2026

View reviewed changes

Comment thread CREDITS.md Outdated

NetsuNegi requested changes Aug 31, 2026

View reviewed changes

dh381-1 added 2 commits September 1, 2026 14:28

update hooks.cpp

6515cd4

update name and doc

2b30541

NetsuNegi reviewed Sep 2, 2026

View reviewed changes

Comment thread src/Ext/Building/Body.h Outdated

update hooks.cpp

a1028c5

TaranDahl approved these changes Sep 7, 2026

View reviewed changes

Coronia and others added 10 commits September 9, 2026 12:37

add missing serialize in 8a3a246

308c53a

make EnemyUIName support unit that disguise as enemy house

86f9386

Weekly Regular Documentation Revisions 08.24-08.30 - develop (Phobos-…

cf9ee11

…developers#2366)

initial

12ead99

update doc

bec5f2f

Merge branch 'develop' into MoneyChangeAnimation

f63c884

dh381-1 requested a review from TaranDahl September 9, 2026 05:11

Coronia added the Needs testing label Sep 9, 2026

Navigation Menu

Uh oh!

Uh oh!

Money switch building active animation - #2380

Money switch building active animation#2380
dh381-1 wants to merge 16 commits into
Phobos-developers:developfrom
dh381-1:MoneyChangeAnimation

dh381-1 commented Aug 31, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NetsuNegi Aug 31, 2026

Uh oh!

NetsuNegi Aug 31, 2026

Uh oh!

NetsuNegi Aug 31, 2026

Uh oh!

NetsuNegi Aug 31, 2026

Uh oh!

phoboscn-bot commented Sep 1, 2026

Uh oh!

Uh oh!

TaranDahl Sep 7, 2026

Uh oh!

TaranDahl commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

dh381-1 commented Aug 31, 2026

What kind of change is this?

Description

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NetsuNegi Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

NetsuNegi Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

NetsuNegi Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

NetsuNegi Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

phoboscn-bot commented Sep 1, 2026

Uh oh!

Uh oh!

TaranDahl Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

TaranDahl commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants