fix(http): preserve upgrades over custom connections - #10899
proggeramlug wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed via merge train 253 (#10918) as v0.5.1633 — merge commit Expedited at the owner's request. Carried with nine other PRs; the stacked ones (#10899/#10900 on #10886, #10901 on #10885) had only their unique commits taken. Evidence on the assembled tree: Closing here rather than merging — a train lands the commits directly. |
Summary
Connection: Upgradewhennode:httpuses a customcreateConnectionsocketupgradewith the same live socket and any buffered head bytesClassRefreads (required for ws states such asWebSocket.CONNECTING)Verification
python3 scripts/check_test_registration.pygit diff --checkserver upgrade,client upgrade 101 probe 0, thenclient data helloon the same socketws@8.21.1fixture advances from HTTP 426 throughclient upgrade 101 websocketandclient openThe next independent ws blocker (the server-side
connectioncallback not firing after the successful upgrade) is tracked in #10898.Stacked on #10886 because the public ws fixture otherwise stops at the dynamic-super failure first.
Closes #10888