Skip to content

fix(http): preserve upgrades over custom connections - #10899

Closed
proggeramlug wants to merge 1 commit into
fix/10660-dynamic-super-evaluationfrom
fix/10888-ws-http-426
Closed

proggeramlug wants to merge 1 commit into
fix/10660-dynamic-super-evaluationfrom
fix/10888-ws-http-426

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Summary

  • preserve caller-supplied Connection: Upgrade when node:http uses a custom createConnection socket
  • parse HTTP 101 responses on that path, detach the raw reader, and emit upgrade with the same live socket and any buffered head bytes
  • make runtime-defined statics on capture-bearing heap class objects visible to earlier ClassRef reads (required for ws states such as WebSocket.CONNECTING)
  • add focused header and compiled end-to-end upgrade regressions

Verification

  • python3 scripts/check_test_registration.py
  • git diff --check
  • remote direct HTTP upgrade fixture: server upgrade, client upgrade 101 probe 0, then client data hello on the same socket
  • public ws@8.21.1 fixture advances from HTTP 426 through client upgrade 101 websocket and client open

The next independent ws blocker (the server-side connection callback not firing after the successful upgrade) is tracked in #10898.

Stacked on #10886 because the public ws fixture otherwise stops at the dynamic-super failure first.

Closes #10888

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 71d1d5db-a7fa-4d25-85cd-c3eb59bf7af8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug

Copy link
Copy Markdown
Contributor Author

Landed via merge train 253 (#10918) as v0.5.1633 — merge commit 0fa3915293.

Expedited at the owner's request. Carried with nine other PRs; the stacked ones (#10899/#10900 on #10886, #10901 on #10885) had only their unique commits taken.

Evidence on the assembled tree: perry-runtime full suite 4233 passed / 0 failed / 0 SIGABRT, perry-hir 471 / 0, cargo check --workspace --all-targets under -D warnings clean, cargo fmt --check clean, and all eight ratchets rc=0. The gap sweep and compiler-output suites were not run.

Closing here rather than merging — a train lands the commits directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant