Fix Penance Brand of Conduction hit rate incorrectly using activation frequency - #10190
Open
cupkax wants to merge 1 commit into
Open
Fix Penance Brand of Conduction hit rate incorrectly using activation frequency#10190cupkax wants to merge 1 commit into
cupkax wants to merge 1 commit into
Conversation
Contributor
Author
|
It'd be great if someone with more experience could take a look at the damage calculations for this. Ta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10124 & #7288 .
Description of the problem being solved:
Penance Brand of Conduction only deals damage when the brand detaches at the end of its attached duration, but its preDamageFunc was a copy of Penance Brand of Dissipation's, which pulses on every activation. So as pboc activates every 100ms, this reported a hit rate of 10+ per second instead of once per brand, which essentially inflated the dps calculation by a few orders of magnitude.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: