Evaluate Trader results with bench craft potential - #10164
Open
mcagnion wants to merge 5 commits into
Open
Conversation
Use Trade affix metadata to track empty prefix and suffix slots separately, then locally rerank fetched results with the best legal bench craft. Show the exact simulated item while Ctrl is held without changing the item imported from the listing.
Make the tooltip explicit that bench craft potential sorts fetched results locally. Align the bench craft tests with the same evaluation vocabulary and the existing flask modifier group name.
Allow a single standard crafted modifier to be removed in the simulation before testing legal replacements. Multicraft items continue to support additions only.
mcagnion
marked this pull request as ready for review
August 7, 2026 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Trader ranks items as they are listed on the trade site. A rare item with an open prefix or suffix, or an item with a replaceable crafted modifier, can therefore appear below a less promising item even when a simple bench craft would make it the better upgrade.
This adds an opt-in
Bench Craftoption to Trade Query Options. When enabled, PoB evaluates crafts that are available for the item type and compatible with its existing modifiers, then reranks the fetched results using the best outcome. It can fill an open prefix or suffix, or replace exactly one existing crafted modifier when the replacement is an improvement. Items with multiple crafted modifiers are only considered for additions; their existing crafts are never replaced.The result tooltip shows the selected craft or replacement, and holding
Ctrlpreviews the simulated item with the new lines marked[Craft]. The option only reranks results already returned by the Trade API. It does not change the trade-site query or the item that gets imported.Steps taken to verify a working solution:
Bench Craftdisabled and enabled, verified the changed order, tested a crafted-mod replacement, and checked the exactCtrlpreview in the UI.Link to a build that showcases this PR:
No specific build is required. The behavior can be reproduced with an equipment search that returns a rare item with an open affix or one replaceable crafted modifier.
Before screenshot:
After screenshot — open affix:
After screenshot — crafted modifier replacement:
Query Options:
Notes: