Enrich internal custom checks with flag showing them as such - #5840
Open
rbev wants to merge 7 commits into
Open
Conversation
rbev
force-pushed
the
rhys/flag-builtin-customchecks
branch
from
September 1, 2026 05:16
9a89855 to
1e06c53
Compare
rbev
marked this pull request as ready for review
September 1, 2026 05:33
jpalac
reviewed
Sep 1, 2026
rbev
commented
Sep 2, 2026
andreasohlund
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements and new tests around the classification and reporting of internal custom checks, as well as enhancements to test coverage and code clarity. The main focus is ensuring that internal custom checks are correctly identified and exposed via the API, and that both primary and audit instances are consistent in their handling and registry of these checks. It also includes some test and project file cleanup to support these goals.
Custom check classification and reporting improvements:
When_custom_checks_are_classified.cs,When_a_persister_check_fails.cs,When_the_body_storage_check_is_reported.cs). [1] [2] [3]docs/data-versioning-design.md).Audit and persistence test improvements:
InternalCustomCheckClassificationin audit and persistence test projects to ensure all custom checks are properly classified and registered, surfacing any missing entries (CustomChecksTest.cs,.csprojupdates, approval files). [1] [2] [3] [4] [5] [6] [7]Code and test cleanup:
CustomCheckViewandCustomChecktypes, improving code clarity and correctness. [1] [2] [3]Persistence API consistency:
CustomCheckViewinstead ofCustomCheckfor stats queries, aligning with API expectations. [1] [2] [3]