Skip to content

Removing gpsLatitude and gpsLongitude, and setting values into latitu… - #203

Open
sehjotsinghunthinkable wants to merge 1 commit into
PSMRI:release-3.12.0from
sehjotsinghunthinkable:feature/lat-long-duplicacy
Open

sehjotsinghunthinkable wants to merge 1 commit into
PSMRI:release-3.12.0from
sehjotsinghunthinkable:feature/lat-long-duplicacy

Conversation

@sehjotsinghunthinkable

@sehjotsinghunthinkable sehjotsinghunthinkable commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

…de and longitude

📋 Description

JIRA ID: AMM-2416

  • ✨ New feature (non-breaking change which adds functionality)

Summary by CodeRabbit

  • Data Updates
    • Beneficiary details no longer include separate GPS latitude and longitude fields. Digipin and GPS timestamp and unavailability details remain.
    • During data synchronization, latitude and longitude are now transferred through the standard coordinate fields, rather than GPS-specific fields. This changes how location coordinates are represented in synchronized records; the remaining GPS-related details are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2a1e159a-8db0-4085-8448-837ff8a92588

📥 Commits

Reviewing files that changed from the base of the PR and between 5634e6d and 3f91c09.


📒 Files selected for processing (2)
  • src/main/java/com/iemr/common/identity/data/rmnch/RMNCHBeneficiaryDetailsRmnch.java
  • src/main/java/com/iemr/common/identity/service/rmnch/RmnchDataSyncServiceImpl.java

💤 Files with no reviewable changes (1)
  • src/main/java/com/iemr/common/identity/data/rmnch/RMNCHBeneficiaryDetailsRmnch.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The RMNCH data sync now assigns GPS coordinates through setLatitude and setLongitude with BigDecimal values. RMNCHBeneficiaryDetailsRmnch no longer declares GPS-specific latitude and longitude fields.

Changes

RMNCH GPS coordinate mapping

Layer / File(s) Summary
Update GPS coordinate field mapping
src/main/java/com/iemr/common/identity/service/rmnch/RmnchDataSyncServiceImpl.java, src/main/java/com/iemr/common/identity/data/rmnch/RMNCHBeneficiaryDetailsRmnch.java
The data sync assigns GPS coordinates using setLatitude and setLongitude with BigDecimal values. The RMNCH details class removes the GPS-specific coordinate fields and mappings.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: vishwab1


Merge Risk: ⚪ Minimal · up to 3f91c

No actionable issue is established for this coordinate-mapping change. The available evidence does not show that it loses distinct coordinates.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes both main changes: removing gpsLatitude and gpsLongitude, and assigning values to latitude and longitude.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@sehjotsinghunthinkable

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant