Skip to content

Fixes #20: Handle missing id in inputs - #24

Merged
sieben-gea merged 4 commits into
mainfrom
issue_21
Sep 3, 2026
Merged

Fixes #20: Handle missing id in inputs#24
sieben-gea merged 4 commits into
mainfrom
issue_21

Conversation

@sieben-gea

Copy link
Copy Markdown
Collaborator

No description provided.

@sieben-gea sieben-gea changed the title Towards #21: Ignore missing input ids in LPJmLInputType Towards #20: Ignore missing input ids in LPJmLInputType Sep 1, 2026
@sieben-gea sieben-gea changed the title Towards #20: Ignore missing input ids in LPJmLInputType Fixes #20: Ignore missing input ids in LPJmLInputType Sep 1, 2026
@sieben-gea
sieben-gea marked this pull request as ready for review September 1, 2026 12:50
@sieben-gea
sieben-gea requested a review from jnnsbrr September 1, 2026 12:50
@sieben-gea sieben-gea changed the title Fixes #20: Ignore missing input ids in LPJmLInputType Fixes #20: Handle missing id in inputs Sep 1, 2026

@jnnsbrr jnnsbrr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One structural remark with suggestion that then could be tested better. Rest fine from my side and useful!

Comment thread pycoupler/config.py Outdated
@sieben-gea
sieben-gea requested a review from jnnsbrr September 3, 2026 09:20

@jnnsbrr jnnsbrr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ready to merge.

@sieben-gea
sieben-gea merged commit 2914b98 into main Sep 3, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants