Skip to content

Improve tap #59

Open
Open

Description

@thomascoumau

Hello, I have already made a PR on this repo to improve passing the tap to the map and I have been working on improving the polyline tap for some month. I have made a PR on flutterMap here, however the maintainer prefer to let this responsibility to this pluggin. I can rework my PR on FlutterMap repo a little to reopen it on this pluggin if you would like to.

Activity

  1. HugoHeneault commented on Oct 18, 2023

    @HugoHeneault
    Contributor

    Yes it would be great! Would you consider waiting for #60 to be merged or base your work on it?

    Thanks alot! :)

  2. thomascoumau commented on Oct 18, 2023

    @thomascoumau
    Author

    I can wait for #60 to be merged of course.

    However in my PR I reworked completely how the package is working. I decided to make a custom paint for each polyline instead of the layer and to implement on override on their hitTest with a touchable path.

    This prevent having to track where on the map the polyline is tapped and also it prevent from having to bother on how to pass the tap on the map below the polylines.

  3. alexbejann commented on Jan 9, 2024

    @alexbejann

    Hey @thomascoumau, did you try to implement these changes into the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions