Conversation
Collaborator
|
@Bing-su Thanks for your contribution! 🌵🚀 |
github-actions
Bot
added
resources
Bing-su
commented
Mar 14, 2026
Comment on lines
+655
to
656
| // This trigger is intended only for Blue Mage, so do not use `data.party.isLimitedJob` here. | ||
| condition: (data, matches) => data.me === matches.target && data.job === 'BLU', |
Collaborator
Author
There was a problem hiding this comment.
As this is a Blue Mage-specific trigger, I left it as it was and simply added a comment.
Bing-su
commented
Mar 14, 2026
Comment on lines
+367
to
+371
| // LimitedJob tends to avail here, so call out your friend. | ||
| if (data.party.isLimitedJob(data.me)) { | ||
| const [otherPlayer] = data.formlessTargets.filter((x) => x !== data.me); | ||
| return { | ||
| alertText: output.formlessBusterBLU!({ player: data.party.member(otherPlayer) }), | ||
| alertText: output.formlessBusterLimitedJob!({ player: data.party.member(otherPlayer) }), |
Collaborator
Author
There was a problem hiding this comment.
I changed both the comment and the trigger name here.
Bing-su
changed the title
Collaborator
|
These changes are very premature right now when we don't know what capabilities BST will have yet, nor any information on if and how it will function in group content. |
Bing-su
marked this pull request as draft
March 17, 2026 11:14
Bing-su
force-pushed
the
fix/party-isLimitedJob
branch
from
March 27, 2026 23:02
c1566cf to
6cad07f
Compare
Bing-su
force-pushed
the
fix/party-isLimitedJob
branch
from
April 29, 2026 13:26
6cad07f to
fe03d70
Compare
Introduces PartyTracker.isLimitedJob(name) which resolves the player's job and uses Util.isLimitedJob to determine if it's a limited job.
Introduce a nameToJob_ map in PartyTracker to store each member's job name, populate it when parsing party data, reset it with the tracker, and update jobName(name) to return from the map.
Bing-su
force-pushed
the
fix/party-isLimitedJob
branch
from
September 8, 2026 07:28
fe03d70 to
2c9cdd4
Compare
Bing-su
marked this pull request as ready for review
September 8, 2026 07:29
Collaborator
|
I think these changes need more consideration. BLU is designed in such a way that it can feasibly tank or heal in group content; BST is not. Simply treating both limited jobs as having the same capabilities is not appropriate at this time. |
Collaborator
Author
|
I agree. Besides, it doesn't seem like there's any reason to do raids with BST anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggers written for Blue Mages are now modified to function for all Limited Job targets.
I also included a refactoring that adds
nameToJob_to PartyTracker.