Repository navigation
Implement node.showIf; move the pin to v0.12.0 - #1
Merged
Merged
Conversation
The contract gained node-level showIf in v0.11.0: advancing to (or stepping onto) a node whose showIf gate fails skips it and continues at its `next`, until a shown node is reached. onEnter of a skipped node does not fire, and a ring of all-failing gates is reported rather than looped. This port pinned v0.9.0 (provisional, pre-showIf) and handled showIf only on choices and ladder rungs. Added the skip walk to advance_node and step_dialogue, mirroring the reference semantics, and updated the step_dialogue conformance check to compare nodeId and the onEnterEffects list the runtime already returns. Vectors re-copied from parlance@v0.12.0; PIN moved to the v0.12.0 tag. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Node-level
showIf(contract v0.11.0): advancing to / stepping onto a gated node whose gate fails skips it and continues at itsnext, until a shown node is reached. SkippedonEnterdoes not fire; a ring of failing gates is reported, not looped.This port pinned a provisional
v0.9.0and handledshowIfonly on choices and ladder rungs.Change
advance_nodeandstep_dialogue: added the skip walk, a faithful mirror of the verified C# port.conformance_runner.gd:step_dialoguecheck now comparesnodeId+ theonEnterEffectslist the runtime already returns.parlance@v0.12.0; PIN moved to thev0.12.0tag.Verification
Not run locally (no Godot in the authoring environment) — this repo's CI (headless Godot 4.4) is the verifier. The logic is a line-for-line translation of the C# port, which passes 9/9 families.