Skip to content

Move Date to core/object - #827

Open
Spartan322 wants to merge 1 commit into
masterfrom
move/date
Open

Move Date to core/object#827
Spartan322 wants to merge 1 commit into
masterfrom
move/date

Conversation

@Spartan322

Copy link
Copy Markdown
Member

Extract core/object/Timespan.hpp from Date.hpp
Move needed constants for Timespan into Timespan class
Expose Timespan constants as transparent Date constants
Split Timespan and Date includes

@Spartan322
Spartan322 requested a review from a team as a code owner August 9, 2026 19:45
@Spartan322 Spartan322 added enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module labels Aug 9, 2026
Comment thread src/openvic-simulation/history/diplomacy/WarHistory.hpp Outdated
Extract `core/object/Timespan.hpp` from `Date.hpp`
Move needed constants for Timespan into Timespan class
Expose Timespan constants as transparent Date constants
Split Timespan and Date includes
@Spartan322 Spartan322 added the topic:tests Issue that applies to the tests of the module, whether it be adding or modifying tests label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module topic:tests Issue that applies to the tests of the module, whether it be adding or modifying tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant