Repository navigation
Keep the 1.0 meaning of tracked time in the API, routines and filters - #1024
Merged
Merged
Conversation
#1008 made a repeating task's tracked total count only its current occurrence everywhere, which changed what tracked_minutes, the routine condition tracked and the filter terms tracked mean. docs/stability.md allows only additions within 1.x, so those surfaces read every entry of the task again, as in v1.0.0, and the current occurrence is added alongside: tracked_minutes_occurrence on repeating tasks and the filter term tracked occurrence (All occurrences turned off in the builder). The row chip and the Time tab keep the per-occurrence figure. OpenSpec change tracked-time-api-compatible (archived). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bkw4TZLFDGeMdZR3vWZF13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #1008 (issue #1004).
Why
#1008 made a repeating task's tracked total count only its current occurrence. That is the right figure in the app, but it also changed what three v1 surfaces mean:
tracked_minutesin the agent tools and MCP, the automation conditiontracked(server and device runner), and the filter termstracked/tracked cmp duration(saved views, routine Find tasks steps).docs/stability.mdallows only additions within 1.x, and "changing what a field means" needs a new major version. #1008 is in no release yet, so restoring the 1.0 meaning now breaks nobody.What changes
The old names go back to the 1.0 meaning, and the new meaning gets new names alongside them.
tracked_minutestracked_minutes_occurrence(new, repeating tasks only)tracked: {min_minutes: 30}tracked >= 30m(saved views, Find tasks)tracked occurrence >= 30m(new)tracked occurrence = 10mmatchestracked occurrencewas a syntax error on 1.0, so no stored query changes meaning. In the condition editor it is the tracked time condition with the new All occurrences switch turned off.task.completed, and completing the task is what starts a new occurrence, so a per-occurrence condition would always read 0 there. A Find tasks step withtracked occurrencecovers it (design D3).Tests
internal/mcpTestTrackedMinutesOfRepeatingTaskpinstracked_minutes40 andtracked_minutes_occurrence10, and checks that a plain task has no new field.internal/rulesTestTrackedKeepsTheTotal: the condition and thetracked/tracked occurrenceFind tasks queries.occurrence_fixture.jsongains the 30/10 case (totals/all_totals);evaluate.vectors.jsongainstracked_occurrencewith cases;formatted.txtis regenerated.filter.test.ts"evaluate: tracked occurrence", the builder round trips, andtimeTab.test.tsx(row 10, filter 50/10).tracked_minutes_occurrence,recurrenceandnext_occurrences.Bundle
The first load is 687.03 KB against 687 KB, so the budget goes up to 688 KB with the reason in
web/bundle-budget.json. The entry chunk is 139.7 KB of 140.OpenSpec
tracked-time-api-compatiblehas a proposal, a design, MODIFIED deltas for time-tracking "Tracked time of a repeating task" and filter-queries "Tracked time terms", and tasks. It is archived.Checks
go test ./internal/timetrack ./internal/agenttools ./internal/mcp ./internal/filter ./internal/rules ./internal/ruleval ./internal/httpapi/..., plus./internal/codesizenpm run build,npm run lint,make bundle-budgetmake i18n-check(two new strings, translated in every catalog),make docs-check,make repo-check,make openspec-validate,make ui-lint🤖 Generated with Claude Code
https://claude.ai/code/session_01Bkw4TZLFDGeMdZR3vWZF13