Adapt private-link retransmission timing - #92
Open
ZivDero wants to merge 11 commits into
Open
Conversation
ZivDero
changed the title
ZivDero
force-pushed
the
network-retransmission-timing
branch
from
August 31, 2026 16:01
423e3fa to
8605188
Compare
ZivDero
force-pushed
the
network-retransmission-timing
branch
from
September 2, 2026 00:48
2073fda to
edc61ff
Compare
ZivDero
force-pushed
the
network-retransmission-timing
branch
from
September 2, 2026 00:53
edc61ff to
a9ee31f
Compare
ZivDero
marked this pull request as ready for review
September 2, 2026 15:23
ZivDero
force-pushed
the
network-retransmission-timing
branch
from
September 2, 2026 15:24
769c546 to
cac13ff
Compare
|
Development builds of 8c5370d: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
Krisztiaan
suggested changes
Sep 5, 2026
Krisztiaan
left a comment
Krisztiaan
left a comment
Contributor
There was a problem hiding this comment.
Can you also possibly consolidate some of the "verbosity" wherever possible?
| /// <summary>Bounds a packet's first retry so the connection timeout allows at least three transmissions.</summary> | ||
| Milliseconds Initial_Retry_Timeout(Milliseconds retransmit_timeout, Milliseconds connection_timeout) | ||
| { | ||
| return(std::max(MINIMUM_RTO, std::min(retransmit_timeout, connection_timeout / 4))); |
Contributor
There was a problem hiding this comment.
This cap can permanently prevent RTT recovery. Make the first-retry policy preserve a path to a clean sample, may be worth to add the corresponding sequence as a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-link RTT/RTO estimation and exponential retransmission backoff. Supports #35.