Remove assumptions about the width of long and of pointers - #154
Open
gunnarbeutner wants to merge 3 commits into
Open
Remove assumptions about the width of long and of pointers#154gunnarbeutner wants to merge 3 commits into
gunnarbeutner wants to merge 3 commits into
Conversation
ZivDero
reviewed
Sep 10, 2026
gunnarbeutner
force-pushed
the
pointer-and-record-widths
branch
from
September 10, 2026 12:05
76c56a9 to
df2212c
Compare
|
Development builds of df2212c: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
| CrateType Crate; | ||
| bool Bool; // Boolean value. | ||
| long Value; | ||
| int Value; |
Contributor
Author
There was a problem hiding this comment.
It's 32-bit on all supported platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the dissolve alpha minimum in DWORD rather than unsigned long
std::min(255ul, ...)compares aDWORDagainst anunsigned long. Deduction fails once those differ. No change where both are 32 bits.Pin the trigger action's Value field to a fixed width
TActionClass::Datais serialized raw into saves.intfixesValueat four bytes so the union cannot widen. Unchanged on MSVC, wherelongis already four.Format the generated type name the way MSVC's %p does
A type built without an INI name takes one from its address.
%phas no portable format, so the name varies by library. Spelling out MSVC's formatting keeps today's string and makes it the same everywhere.