Skip a tag without a trigger when a variable resets timers - #147
Open
gibbo101 wants to merge 1 commit into
Open
Conversation
MahBoiDeveloper
suggested changes
Sep 8, 2026
| { | ||
| Trigger->Reset_Global_Linked_Timed_Events(global); | ||
| // A tag outlives a destroyed trigger with no link to take its place. | ||
| if (Trigger != NULL) { |
| void TagClass::Timer_Local_Reset(int local) | ||
| { | ||
| Trigger->Reset_Local_Linked_Timed_Events(local); | ||
| if (Trigger != NULL) { |
Author
|
Changed both checks to nullptr. |
gibbo101
force-pushed
the
tag-timer-reset-without-trigger
branch
from
September 8, 2026 20:15
0934236 to
12f535a
Compare
MahBoiDeveloper
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tag whose trigger has been destroyed keeps a null
Triggerwhen the destroyed trigger had noLinkedToto take its place (DetachsetsTrigger = Trigger->LinkedTo). A trigger action that sets a local or global variable then callsTimer_Local_Reset/Timer_Global_Reseton every tag, and the dereference through that null pointer crashes the game. This skips a tag without a trigger so the action completes and the other tags' timers restart as before.Behavior: fixed. No compatibility boundary changes: no data format, save, or network representation changes; the reset runs identically on every peer.
Validation: hit in play on my controller fork, where this change has been running since. Built with the fork's experimental clang-cl cross build and CTest passes 18/18 there. I have not run the supported MSVC Win32 build; CI will cover it.
Documentation:
manual/changes/tag-timer-reset-without-trigger.md(fix, targets the trigger springing system).manage.py check --base-ref mainpasses.