Replace the compound-file save container and remove COM from the object model - #140
Merged
Merged
Conversation
gunnarbeutner
force-pushed
the
savegame-and-com
branch
from
September 6, 2026 23:43
ab9a3c7 to
78a497d
Compare
gunnarbeutner
force-pushed
the
savegame-and-com
branch
from
September 7, 2026 00:06
78a497d to
e84859e
Compare
gunnarbeutner
marked this pull request as ready for review
September 7, 2026 00:50
gunnarbeutner
force-pushed
the
savegame-and-com
branch
from
September 7, 2026 00:56
e84859e to
2717464
Compare
|
Development builds of e8fb6ce: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
gunnarbeutner
force-pushed
the
savegame-and-com
branch
2 times, most recently
from
September 7, 2026 10:48
2717464 to
b75aa00
Compare
tomsons26
requested changes
Sep 7, 2026
tomsons26
left a comment
tomsons26
left a comment
Contributor
There was a problem hiding this comment.
Way way way too much is being done in this PR, split it in seperate PRs
gunnarbeutner
marked this pull request as draft
September 7, 2026 16:38
gunnarbeutner
force-pushed
the
savegame-and-com
branch
from
September 9, 2026 09:56
6a11983 to
07f7a77
Compare
gunnarbeutner
force-pushed
the
savegame-and-com
branch
2 times, most recently
from
September 9, 2026 10:38
fecbbe0 to
2478f7b
Compare
gunnarbeutner
marked this pull request as ready for review
September 9, 2026 10:43
Contributor
Author
|
Now that the LZO stuff has landed I've rebased this on top of it (and fixed some minor correctness issues). |
gunnarbeutner
force-pushed
the
savegame-and-com
branch
from
September 9, 2026 21:11
2478f7b to
525832c
Compare
Member
|
Alright, I made some various fixes here and there. Overall, pretty good. If you're good with the changes I'll merge. |
ZivDero
force-pushed
the
savegame-and-com
branch
from
September 10, 2026 02:24
3a1762c to
e8fb6ce
Compare
Contributor
Author
|
Aye, looks good to me. Go for it. |
gunnarbeutner
force-pushed
the
savegame-and-com
branch
from
September 10, 2026 05:37
e8fb6ce to
525832c
Compare
ZivDero
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a custom format for save games that's independent of compound documents. It also hardens the compressed blobs so that heap overwrites using maliciously crafted save games isn't possible anymore.
With compound files gone this also then removes most other uses of COM, e.g. for locomotors. Compatibility with custom RULES.INI files is kept.