Fix shroud stack overflow and the F4 playtest (un)shroud toggle - #132
Open
torradmin wants to merge 3 commits into
Open
Fix shroud stack overflow and the F4 playtest (un)shroud toggle#132torradmin wants to merge 3 commits into
torradmin wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related fixes to shroud/fog handling:
DisplayClass::Fog_Cellregrew fog by recursing into every neighboring cellthat also needed to regrow. Unshrouding or reshrouding a large connected
area (a big map, a reveal-the-map crate) could recurse deep enough to
overflow the stack and crash. It now walks an explicit queue instead.
never touched the underlying shroud data, so pressing it did nothing
visible. It now reveals/reshrouds the map through the same path the
reveal-the-map and blackout crates use, and
MapClass::Is_Shroudednowalso sees through an active toggle so shroud checks agree with the redraw.
Behavior classification
Both are fixed: they correct behavior that conflicts with the project's
goals (a crash, and a non-functional debug control). No compatibility
boundary is affected — this is runtime logic only, with no change to saves,
replays, network protocol, formats, or configuration.
Documentation
Added two manual change records under
manual/changes/, both targetingrelease 0.2.0:
stack-overflow-on-mass-shroud-unshroud.md(system:map-visibility)f4-debug-unshroud-toggle.md(command:fixed:debug-unshroud)Validation