Remove woldata.key serial verification - #120
Draft
Belonit wants to merge 1 commit into
Draft
Conversation
Belonit
marked this pull request as draft
September 3, 2026 12:55
Contributor
Author
|
I think this change needs testing, which I haven't done yet, so I'll mark PR as Draft |
Member
|
Do we have solid reaso to preserve GPacket size? |
Krisztiaan
reviewed
Sep 3, 2026
| NetCommandType Command; // One of the enum's defined above | ||
| char Name[MPLAYER_NAME_MAX]; // Player or Game Name | ||
| char Serial[SERIAL_MAX]; // | ||
| char Reserved[GLOBAL_PACKET_RESERVED_SIZE]; // Reserved for global packet compatibility. |
Contributor
There was a problem hiding this comment.
Every join packet zero-initializes this field, all clients from this branch present the same empty serial. A base-head host still counts that field and rejects the third matching guest. May want to populate the bytes with a unique value for old-compatible joins, or explicitly drop and document mixed-version compat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the obsolete
woldata.keyserial-number verification path from the LAN/IPX lobby flow.The multiplayer packet layout remains compatible with existing clients, the former serial field is retained as reserved padding.