Report VQA errors through a typed enum - #103
Open
mischa85 wants to merge 2 commits into
Open
Conversation
mischa85
added a commit
to mischa85/OpenTS
that referenced
this pull request
Sep 2, 2026
mischa85
added a commit
to mischa85/OpenTS
that referenced
this pull request
Sep 2, 2026
mischa85
added a commit
to mischa85/OpenTS
that referenced
this pull request
Sep 3, 2026
|
Development builds of e5372bd: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
Krisztiaan
approved these changes
Sep 3, 2026
Krisztiaan
left a comment
Krisztiaan
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, conflicts with #108
mischa85
force-pushed
the
vqa-error-type
branch
from
September 8, 2026 21:31
e5372bd to
ebfed28
Compare
mischa85
force-pushed
the
vqa-error-type
branch
from
September 8, 2026 21:34
ebfed28 to
1f1ec8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 26
VQAERR_*macros becomeenum VQAErrorType : int32_t.Left alone where the return is genuinely multiplexed:
VQA_Play/VQA_SeekFrame(frame number or negative error),VQA_H_FUNC(pointer forVQAEVENT_LOCK), and a few returning counts or indices.Found in passing: an
HRESULTand aVQAERR_*sharing one variable inPlay_Audio_Handler, a bare-4meaningVQAERR_READ, and two unsigned ints holding negative codes.