Skip to content

🔥 chore(docs): delete the resurrected docs/ stub, and correct what it means - #69

Open
vtempest wants to merge 2 commits into
masterfrom
claude/brave-dirac-eww1id
Open

vtempest wants to merge 2 commits into
masterfrom
claude/brave-dirac-eww1id

Conversation

@vtempest

@vtempest vtempest commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Do not merge before flipping the Pages Source

This PR is half of a two-step fix, and it is the half that does nothing on its own. Merging it while Settings → Pages → Source is still Deploy from a branch → /docs leaves the branch build with nothing to publish.

  1. Settings → Pages → Source = "GitHub Actions" — dashboard-only, no commit can do it
  2. Then merge this

This does not affect Vercel: the root vercel.json builds from the repository root with --filter=grab-help-docs and never reads docs/.

What's wrong today

Both hosts, checked directly:

https://grab.js.org/                       200, 174 kB, the Fumadocs app   ✅
https://opensourceagi.github.io/GRAB-URL/  200, 708 bytes of Jekyll stub   ❌
https://opensourceagi.github.io/GRAB-URL/docs                        404   ❌

docs/ came back in 25e0c46 after PR #47 removed it, and Pages Source is still branch-based, so two publishers contend for one site. GitHub's pages build and deployment keeps winning — it runs and succeeds even on commits where pages.yml's own paths filter skips our workflow, which is only possible when Source is a branch.

Our Deploy docs to Pages builds fine every time and then dies in its deploy job:

Current status: purging_cdn
##[error]Timeout reached, aborting!

Twice in a row, on 9435e0c (run #38) and e762e04 (run #39). actions/deploy-pages@v5 cannot finish a CDN purge for a site something else owns. The build job is green in both.

docs/README.md states the cause in its own words: "GitHub Pages is configured to deploy from this branch's /docs folder."

Changes

d567e68 — delete docs/, correct what it means

  • Removed docs/README.md, docs/_config.yml, docs/index.html. Nothing references them; verified by grep across the repo.
  • .claude/architecture/documentation.md asserted the opposite on both counts — that the folder was gone and that Source was "GitHub Actions" — and offered the then-green deploy-pages run as proof of the latter. It now describes what is actually deployed, records the purging_cdn signature so the next reader recognises it, and gives the two steps in order.

6a6ac96 — grab.js.org is up; Pages is the broken one now

  • The same file said grab.js.org was down and Pages was "the working copy of the site while Vercel is broken". That is now exactly inverted, so both the section and the deployments table are rewritten to past tense. The dashboard settings they name are kept — those still have to stay as they are.

Verification

  • turbo run build --filter=grab-help-docs — 4/4 tasks successful
  • No dangling references to the deleted files anywhere in the repo
  • grab.js.org confirmed serving current master: the comparison table's linked library names, no Size row, and all eight framework tabs on /docs/examples

🤖 Generated with Claude Code

https://claude.ai/code/session_01Lg3gMyaXRLJyWhKzayAfz5

… means

The GitHub Pages site has not been serving the docs app. It serves 708 bytes of
Jekyll redirect:

    https://opensourceagi.github.io/GRAB-URL/       200, the docs/ stub
    https://opensourceagi.github.io/GRAB-URL/docs   404

`docs/` came back in `25e0c46` after PR #47 removed it, and Pages Source is
still "Deploy from a branch", so two publishers contend for one site. GitHub's
branch-based `pages build and deployment` keeps winning — it runs and succeeds
even on commits where `pages.yml`'s own `paths` filter skips our workflow, which
is only possible when Source is a branch. Our `Deploy docs to Pages` builds
fine every time and then dies in its deploy job:

    Current status: purging_cdn
    ##[error]Timeout reached, aborting!

Twice in a row, on `9435e0c` and `e762e04`. `actions/deploy-pages@v5` cannot
finish a CDN purge for a site something else owns.

`architecture/documentation.md` asserted the opposite on both counts — that the
folder was gone and that Source was "GitHub Actions" — and offered the green
`deploy-pages` run as proof. It is corrected here to describe what is actually
deployed, with the CDN timeout recorded so the next reader recognises it.

**Merging this is only half the fix, and the half that does nothing alone.**
Settings → Pages → Source must be set to "GitHub Actions" first; that is
dashboard-only and no commit can do it. Removing the folder while Source is
still `/docs` leaves the branch build with nothing to publish.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg3gMyaXRLJyWhKzayAfz5
@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
grab-url Ready Ready Preview Sep 18, 2026 12:38pm UTC

Checked both hosts while writing the previous commit's diagnosis, and the note
had them backwards:

    https://grab.js.org/                       200, 174 kB, the Fumadocs app
    https://opensourceagi.github.io/GRAB-URL/  200, 708 bytes of Jekyll stub

grab.js.org carries current master — the comparison table's linked library
names, no Size row, and all eight framework tabs on /docs/examples are live
there. The root `vercel.json` plus an empty Root Directory is what fixed it.

So the "grab.js.org is down" section, and the table row calling it down, are
rewritten to past tense; the dashboard settings they name are kept, because
those still have to stay as they are. The tail claiming Pages is "the working
copy of the site while Vercel is broken" is now exactly inverted, and says so.

Deleting `docs/` does not touch Vercel: the root `vercel.json` builds from the
repository root with `--filter=grab-help-docs` and never reads that folder.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lg3gMyaXRLJyWhKzayAfz5
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants