Repository navigation
fix(endgame): match the vendor OT handshake and interface - #241
Merged
Merged
Conversation
Found by reading the vendor app (v1.6.400) against the driver: - open a session with kComSetPasswd (static vendor password), then the firmware version, before any profile query; silence is traced, not fatal - accept a lone response packet: the vendor treats the ACK as seen after every write, so a query no longer needs an ACK first - claim only the 0xFFA1:0x00A5 interface the vendor opens; other interfaces of the same PID refuse feature-report writes Refs #237 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 4
✨ Finishing Touches
Comment |
|
🎉 This PR is included in version 0.45.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From reading the vendor app (Endgame Gear Configuration Software 1.6.400,
main-es2015.js~6198-6374) against the OT driver. None of this is verified on hardware yet.kComSetPasswd(static 32-byte vendor password, packet id 0), thenkComQueryFirmwareVersion, before any profile query. The vendor carries on if the mouse is silent here, so failures are traced, not thrown.exchange()/sendPacket()previously required an ACK first and swallowed a lone response.isSupportednow requires the0xFFA1:0x00A5collection with feature report 0, the only interface the vendor opens. The other interfaces of the same PID are standard mouse/keyboard collections that Chrome refuses writes on (theNotAllowedErrorin [Endgame Gear] OP1 RGB (0x1905) wired: no answer to OT profile block 0 — first hardware report against unverified OT driver #237).Refs #237 (does not close it until a hardware handshake succeeds).
The web app's picker filter may also need the usage page so users are not offered the wrong interface.
🤖 Generated with Claude Code
Summary by CodeRabbit