Fix DwaBase attribute lookup with C++20 - #8
Open
gripeyes wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jakub Svoboda <132791205+jacobfreedom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
patch
Issues/Tickets:
OpenMoonRay/openmoonray#276
Release notes comment:
Fixed DwaBase scatter-tag attribute lookup when building with C++20.
Comments for the reviewer:
This is a minimal extraction from the Houdini 22 macOS validation branch.
mRequiredAttributesstores integer attribute indices, whilesScatterTagis an attribute key. The comparison now usessScatterTag.getIndex(), avoiding the incompatible key-to-integer comparison under C++20.The PR contains one functional line change. Unrelated whitespace from the original validation commit was removed.
Umbrella validation PR:
OpenMoonRay/openmoonray#276
Houdini 22 build notes:
https://github.com/gripeyes/openmoonray/blob/test/houdini22-clean-build/building/macOS/Houdini22_build_notes.md
Look or scene setup change:
Special notes for production:
Attention/Reviewers:
AI Assisted Development:
Assisted-by: OpenAI Codex / GPT-5.6
Checklist: