Feature/native moonray spotlight - #10
Open
gripeyes wants to merge 4 commits into
Open
Conversation
Signed-off-by: Nick Shelton <nick.shelton@dreamworks.com>
Signed-off-by: Nick Shelton <nick.shelton@dreamworks.com>
Signed-off-by: nick <nshelton@gmail.com>
Signed-off-by: Jakub Svoboda <132791205+rolledhand@users.noreply.github.com>
Author
|
A bit of reasoning behind this, it's partially a small redesign (it's necessary for Hou in this case) & the general "artist perspective/case" if I use that term. There's USDLux shaping, it's way more trimmed than the native Moonray spolight control-wise, why not expose it in a dedicated tab that's easy to use? Click a checkbox & get better controls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Compatibility:
minor
Issues/Tickets:
OpenMoonRay/openmoonray#276
#5
Release notes comment:
Added an optional native MoonRay SpotLight override to Houdini Solaris lights.
Comments for the reviewer:
This PR is stacked on Nick’s #5 update.
The Houdini parameter generator now adds a Native SpotLight tab to supported USD light types. Enabling the override switches the generated MoonRay class to
SpotLightand exposes its projector-style controls inside that tab.The controls are grouped under SpotLight and Falloff headings, including:
The standard Solaris Shaping tab remains the renderer-neutral USD ShapingAPI path.
This contains only the Python generator change. Generated
.dsfiles and other derived artifacts are intentionally excluded.Look or scene setup change:
Existing lights are unchanged unless the native MoonRay SpotLight override is explicitly enabled.
Special notes for production:
Generated Houdini parameter definitions must be refreshed after applying this change.
Depends on #5.
Attention/Reviewers:
@nshelton-dwa
AI Assisted Development:
Assisted-by: OpenAI Codex / GPT-5.6
Checklist: