Fix/nonblocking athena udp logging - #11
Open
gripeyes wants to merge 1 commit into
Open
Conversation
Author
|
Hi @gonsolo , if you could sign the CLA so this PR can get merged smoothly it'd be amazing! |
Contributor
|
I signed this long ago but since most of my PRs were ignored I stopped looking. |
Author
|
Ahh, idk why the resign isn't picking up your previous one tbf. I'm not from dreamworks/moonray team fyi, just a contributing to open-source as well. I'll leave it up to them. (Noticed things moving forward a bit, so I started pushing some stuff further from my older massive PR) |
Contributor
|
I signed again, I think it's required again because they moved to the Academy Foundation. |
Author
|
Thanks, we're in orange now. Some thing have changed w/ ASF when it come to the sign-offs. Let's see how it goes & if it gets merged, thanks for the contribution eitherway! :) |
Contributor
Signed-off-by: Jakub Svoboda <132791205+jacobfreedom@users.noreply.github.com>
gripeyes
force-pushed
the
fix/nonblocking-athena-udp-logging
branch
from
September 1, 2026 07:56
150d736 to
54b3a7e
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
patch
Issues/Tickets:
OpenMoonRay/openmoonray#276
#8
Release notes comment:
Prevented unavailable Athena UDP logging from blocking or aborting Arras rendering sessions.
Comments for the reviewer:
This PR is stacked on #8, which already provides the required Boost.Asio modernization. Once #8 merges, this PR will contain only the non-blocking logging change.
Athena UDP logging runs inline from latency-sensitive Arras message paths. When no local syslog endpoint is draining port 514, a blocking send or repeated send errors can interrupt scene updates.
This change:
error_codesend overloadThe historical Boost resolver change was excluded because it is already covered by #8. An intermediate macOS EINVAL exception workaround was also excluded because this final implementation supersedes it.
Umbrella validation PR:
OpenMoonRay/openmoonray#276
Houdini 22 build notes:
https://github.com/gripeyes/openmoonray/blob/test/houdini22-clean-build/building/macOS/Houdini22_build_notes.md
Look or scene setup change:
No expected look change.
Special notes for production:
Athena UDP telemetry is best-effort and may be dropped when its destination is unavailable rather than delaying rendering.
Attention/Reviewers:
AI Assisted Development:
Assisted-by: OpenAI Codex / GPT-5.6
Checklist: