Repository navigation
fix(attribution): credit sources without an unstated licence - #729
Merged
Merged
Conversation
A credit whose licence is unknown read "Kölner Verkehrs-Betriebe AG (Licence not specified)", and ÖBB's showed the catalogue's placeholder "(todo)". Credits now name such a source alone; detail views show an unstated licence only as a link to its source's terms. Admin and legal tables still say when a licence is not specified.
Medformatik
enabled auto-merge (squash)
October 31, 2026 22:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A station board's data sources read "Kölner Verkehrs-Betriebe AG (Licence not specified)" for four sources, and "ÖBB-Personenverkehr AG (todo)" for a fifth. Saying that a licence is not specified tells a reader nothing, and the text was English in every UI language.
Do we know these licences? No. These sources are the operators' HAFAS journey planners, which OpenMapX reaches through the transport-apis catalogue:
"isProprietary": true.Transitous's data licence varies by feed and is already shown that way. Its "Licence not specified" came from a second entry for its endpoint, which has terms but no licence.
Changes:
creditLicensingin core):licenceNotSpecifiedstring is no longer used and is removed.Köln Messe/Deutz departures. Before (openmapx.com):
After (local web build of this branch against openmapx.com):
The Credits dialog after: Transitous keeps "Varies by item" and its terms link, and the operators are named alone.
The map footer's MapTiler credit loses its "Licence not specified" link to MapTiler's cloud terms. MapTiler's terms binding is marked for the details view, not the visible credit, and the copyright links stay.
Validation:
check-typespasses forapps/api,apps/webandpackages/core, and Biome is clean.Release and upgrade impact
Product impact: ordinary
No package release: the built
@openmapx/extension-cliand@openmapx/extension-contractspackages are byte-identical tomain(both built and compared, 42 files); the changed shared code is credit rendering in@openmapx/coreand two web locale strings, which they don't ship.extension-contracts' type declarations order some union members differently between builds of the same commit, so the comparison used builds that came out in the same order.