Repository navigation
fix(search-osm-aliases): return no suggestions until an index is built - #727
Merged
Merged
Conversation
The provider read osm_search.index_state on every request, so a server whose data-manager never built the OSM alias index failed each suggestion request in Postgres. Check that the table exists first, as the notable-places provider and this integration's health check do.
Medformatik
added
the
integration
Medformatik
enabled auto-merge (squash)
October 31, 2026 21:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OSM alias suggestion provider queried
osm_search.index_stateon every suggestion request, also on a server where the data-manager has never built that index. Without the index theosm_searchschema does not exist, so every such request failed in Postgres (relation "osm_search.index_state" does not exist; logged three times on 31 Oct on the home server, where the index has never been built). Search was unaffected apart from that: the failure was dropped and alias suggestions were simply missing.The provider now first checks that the table exists and returns no suggestions until it does, like the notable-places provider already does and this integration's own health check (which reports
unconfigured).Validation:
search-osm-aliasestests: pass, including a new one asserting that the provider returns nothing and reads nothing more when the index does not exist.turbo run check-types --filter=@openmapx/api...,biome check,pnpm check-duplicates: pass.Release and upgrade impact
Product impact: ordinary