Skip to content

Add HIP support - #2127

Draft
IAlibay wants to merge 2 commits into
mainfrom
hip-patch
Draft

Add HIP support#2127
IAlibay wants to merge 2 commits into
mainfrom
hip-patch

Conversation

@IAlibay

@IAlibay IAlibay commented Aug 6, 2026

Copy link
Copy Markdown
Member

Main issue with this is that there's no real way to test this in CI...

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes / no
If yes, please provide details here: no

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.
  • Filled in the AI generated code disclosure.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

No API break detected ✅

View workflow run

Griffe output
$ griffe check "openfe" -s src --no-inspection --no-color --verbose -a origin/main

$ griffe check "openfecli" -s src --no-inspection --no-color --verbose -a origin/main

@jameseastwood jameseastwood mentioned this pull request Aug 11, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant