Support the 12PSSSS3 camera identity variant - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Hardware-specific recovery behavior and validation changes require final human review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds support for the 12PSSSS3 camera identity variant and associated HWCONFIG fields.
Changes:
- Validates and normalizes supported identity, date, and check fields.
- Preserves unit-specific data while updating fingerprints.
- Adds tests and fourth-camera validation documentation.
| File | Description |
|---|---|
tests/test_implementation.py |
Updates recovery and manifest tests. |
tests/test_hwconfig_variants.py |
Adds identity, date, and normalization tests. |
hardware-recovery/TEST_RESULTS.md |
Records fourth-camera validation results. |
hardware-recovery/TECHNICAL_DETAILS.md |
Documents the expanded contract. |
hardware-recovery/REFERENCE_FINGERPRINTS.json |
Updates supported identities, ranges, and hashes. |
cc2camera/image.py |
Implements variant and HWCONFIG validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
12PSSSS3serial and UOID structures alongside12PSSSS40x7D200A–0x7D200C2026-03-02and2026-04-01calendar-shaped fields at0x7D206F–0x7D20720.8.0to0.9.0for the follow-up releaseRecovery continues to preserve the complete input HWCONFIG partition and the camera's own serial. No camera dump or full identifier is committed.
Evidence
The fourth camera's stable multi-read dump has SHA-256
574c71e6572093ea1b65c3ca9c3e5e1dd1e55d71443ca7b282db8ce700c45c85. Boot, kernel, root, system, partition layout, and every non-unit HWCONFIG byte match the supported family. Its exhausted config is 98.761% non-FF, with 634 CRC-valid nodes and 632 obsolete nodes.Validation
python -m unittest discover -s tests -q— 165 tests passedgit diff --checkpassedc28fdd1865219a82dd815bea3333acba91091ac809721b130e805adb53062b66The contributor confirmed multiple independent reads with matching MD5 values. Only one representative copy was available in this environment, so the local recovery-generation check used the explicit reduced-read option. This is software validation; the new variant has not been flash/boot-tested through this PR.