server/activity: send correct button data - #141
Open
homomorphist wants to merge 1 commit into
Open
Conversation
Milkshiift
added a commit
to Milkshiift/arrpc
that referenced
this pull request
Feb 13, 2025
Vendicated
pushed a commit
to Vencord/arrpc
that referenced
this pull request
Sep 7, 2026
commit 1d58057 Author: katini <4649286+Agapurnis@users.noreply.github.com> Date: Sun Feb 9 02:15:06 2025 -0800 send correct button data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the C# project mentioned in #71 didn't include this in their own implementation, so it's not super apparent that it's also supposed to be sending back the button data in the same form as was emitted.
I noticed this because https://github.com/jewlexx/discord-presence didn't fully cooperate with Vencord because it complained it was deserializing the response incorrectly, so after inspecting the raw response I noticed the difference.
2025/June/23: Downstream accommodation in jewlexx/discord-presence#139