Repository navigation
fix(redis): reject malformed RESP3 reply boundaries - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject malformed RESP3 doubles with an empty fractional part and pushes nested within another value, following the official protocol. Decoder failures remain sticky so malformed input cannot expose a following reply as a valid response.
Permanent tests also preserve existing owning pipeline prefixes and single completion across protocol failure, disconnect and cancellation. Public client interfaces, cancellation/draining contracts and wire support are unchanged. The bilingual Redis configuration reference documents these boundaries.
Validation: the two decoder regressions fail against main and pass with the fix. Local Boost and Standalone Asio/TLS client, decoder and shutdown checks pass, including AddressSanitizer plus UndefinedBehaviorSanitizer; independently configured external-Redis cases were skipped. Complete clang-format 18 and Nimbus/export checks pass. Hosted cross-platform acceptance remains required.