Repository navigation
fix(fec): release incomplete groups after staging exceptions - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An allocation failure during FEC input staging could leave a shard marked present without complete stored bytes, causing a valid retry to be discarded. Release the incomplete recovery group and its retention accounting when internal staging unwinds, while propagating the original exception.
Preserve user delivery-callback exception behavior, public APIs and ARQ/FEC wire formats. Permanent tests cover systematic/parity allocation failures, legal retries with ordered exactly-once ARQ application delivery, and callback exceptions. English and Chinese FEC guidance states the boundary without promising endpoint retries.
Validation: the permanent regression fails against main. Boost and Standalone Asio 1.38.0 each pass the seven existing related checks (76 cases); FEC passes 21 cases under AddressSanitizer plus UndefinedBehaviorSanitizer. Complete clang-format 18/spacing and Nimbus/HTML/Markdown/AI checks pass. Local macOS validation; hosted cross-platform acceptance remains required.