Repository navigation
fix: ship the MCP declaration in the directory bundle - #73
Merged
Merged
Conversation
The portal rejected the bundle with "Keep the existing MCP connection": the published listing has an MCP connection, and an update that omits the declaration is not accepted. The packager used to strip `mcpServers` and `.mcp.json` for the Skills-only upload path, which does not apply to this listing. The bundle now keeps `mcpServers: "./.mcp.json"` in the manifest and copies `.mcp.json` to the bundle root. The source gate checks that `.mcp.json` is a JSON object with a non-empty `mcpServers`, and the bundle gate checks the field and the file. The self-test covers a tree without the declaration.
sherwinski
requested review from
abdulraqeeb33,
fadi-george,
kalley and
nan-li
and removed request for
kalley
October 14, 2026 21:52
fadi-george
approved these changes
Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Line Summary
scripts/package_directory_bundle.pynow keepsmcpServers: "./.mcp.json"in the bundle manifest and copies.mcp.jsonto the bundle root, so the OpenAI plugin directory accepts the zip as an update to the OneSignal listing.Motivation
The upload of the 1.2.1 zip passed the name check and then failed with:
The packager was written for the portal's Skills-only upload path, which rejects
mcpServersand.mcp.json(mcp_configuration_excluded). The OneSignal listing is not a Skills-only plugin: it has an MCP connection, and the portal treats an update that omits the declaration as a removal, which it does not support. The declaration therefore has to ship in the package.Scope
This PR fixes the 3 portal findings that followed the name fix, in commit order: the missing MCP declaration, the Skills-only wording, and the listing rules (subtitle length, support URL).
scripts/package_directory_bundle.py:bundle_manifestsetsmcpServersto./.mcp.jsoninstead of removing it.build_bundlecopies.mcp.jsonto the bundle root.check_mcp_config:.mcp.jsonmust be a JSON object with a non-emptymcpServers.mcpServers == "./.mcp.json"and the file; the 2 checks that rejected MCP configuration are gone..mcp.jsoninto each test tree and has a new case, "tree without the MCP declaration".AGENT.md: the manifest row, the bundle section, and the gate bullet say that.mcp.jsonships and why..codex-plugin/plugin.json:shortDescriptionis "Set up push, email, and SMS" (27 characters);supportURLis the repository issues page; the long description drops "market leading" and "free" after the portal's advisory findings.displayNameandshortDescriptionat 30 characters and requires the 4 listing URLs as HTTPS, with a self-test case for each..mcp.jsonitself is unchanged:onesignal->https://api.onesignal.com/mcp/oauth.Testing
python3 -m py_compile scripts/*.pypassed.python3 scripts/package_directory_bundle.py --checkprintedbundle check passed (version 1.2.1; nothing written).python3 scripts/package_directory_bundle.py --self-testpassed all 17 cases, including the new one.python3 scripts/package_directory_bundle.py --out /tmp/bundlebuilt a bundle with.codex-plugin/,.mcp.json,assets/, andskills/at the root. The manifest hasnameapp-6a3d93b924488191bdb7eb40fc4219e6,skills./skills/, andmcpServers./.mcp.json. The copied.mcp.jsonmatches the repository file..mcp.jsonmust match the URL of the connection the portal already holds.Affected code
Checklist