Skip to content

refactor(stamina): improve regeneration event dispatch, resolve Sonar issues and expand tests - #104

Merged
theEvilReaper merged 7 commits into
developfrom
feature/stamina
Aug 6, 2026
Merged

refactor(stamina): improve regeneration event dispatch, resolve Sonar issues and expand tests#104
theEvilReaper merged 7 commits into
developfrom
feature/stamina

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

This PR fixes a bug in ExplodeBar where BomberRequireSpawnEvent was repeatedly dispatched during regeneration, ensuring it only fires once and transitions back to READY when full. Additionally, it resolves Sonar static analysis warnings across ExplodeBar and ShootBar by correctly overriding equals/hashCode and eliminating floating-point increment/decrement operators.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Test results

132 files  132 suites   1m 34s ⏱️
117 tests 115 ✅ 2 💤 0 ❌
351 runs  345 ✅ 6 💤 0 ❌

Results for commit 681f5fe.

@theEvilReaper
theEvilReaper merged commit 7a8bbd5 into develop Aug 6, 2026
8 checks passed
@theEvilReaper
theEvilReaper deleted the feature/stamina branch August 6, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant