Repository navigation
fix(ui): use themed dialogs and draw floors from the start room - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The quit and save dialogs were native message boxes, which show their buttons in the language of the operating system and ignore the dark theme, so an English question came with e.g. German yes and no buttons. They are replaced by a small dialog in the style of the application with buttons that name the action, such as Quit and Cancel, and that takes the focus so Enter and Escape work right away. Floors were drawn in the order the generator created the rooms, which made rooms appear scattered and unconnected across the map. They are now drawn step by step from the start room through the doors and teleports, with big boss rooms appearing at once and the secret rooms revealed last.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply