Repository navigation
feat(ui): choose the floor id for the next floor - #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The floor id could only be set with the command line option when starting the UI and was not stored in the floor JSON, although floors depend on the seed and the floor id since the generator improvements. The JSON now contains the floor id, older files without it still load, and the seed stability test only hashes the floor content so new metadata does not change the pinned floors. The UI has a floor field next to the next seed, Page Up and Page Down change it, and the status bar shows the seed, floor id and history position of the shown floor. This also fixes the history, which contained every discarded attempt of a generation instead of only the final floor.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply