Repository navigation
chore(ci): run the ui tests with xvfb - #132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The CI runner has Tkinter but no display, so the 17 tests that open a Tkinter window were skipped on every run while the job still passed. The workflow now installs Xvfb and runs pytest through xvfb-run, so all UI tests run in CI. A shared test helper fails the UI tests instead of skipping them when REQUIRE_UI_TESTS=1 is set, which CI does, so they cannot be skipped silently again. Renovate now extends config:recommended instead of the deprecated config:base preset.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply