Repository navigation
fix: ignore floor shortcuts while typing in the seed field - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Space and the arrow keys were bound to the whole window, so typing a space in the next seed field immediately generated a floor and moving the cursor with the arrow keys switched between floors. These shortcuts are now ignored while the seed field or a button has the focus. Pressing enter generates a floor and leaves the field, escape leaves it without generating, and clicking the floor also removes the focus from the field, so the shortcuts work again right away.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply