Skip to content

test: pin generated floors for fixed seeds - #128

Merged
Joltras merged 2 commits into
devfrom
test/seed-stability
Nov 3, 2026
Merged

Joltras merged 2 commits into
devfrom
test/seed-stability

Conversation

@Joltras

@Joltras Joltras commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Proposed changes

Existing seeds must keep producing the same floors, so a new test stores hashes of 330 generated floors across 55 seeds and floor ids 0 to 5 and fails if any of them changes. The hashes are taken from the canonical JSON content, so formatting changes do not affect them, and they are identical on Python 3.12, 3.13 and 3.15. The super secret room distance limit is now a named constant, and the room amount formula was simplified to an equivalent integer division. A comment explains that the generator can place a few more rooms than the calculated amount, which is kept on purpose so existing seeds stay unchanged.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@Joltras
Joltras merged commit df33001 into dev Nov 3, 2026
4 checks passed
@Joltras
Joltras deleted the test/seed-stability branch November 3, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant