Skip to content

fix(page): improve id determination - #176

Merged
theEvilReaper merged 2 commits into
mainfrom
fix/customPage
Aug 11, 2026
Merged

fix(page): improve id determination#176
theEvilReaper merged 2 commits into
mainfrom
fix/customPage

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Currently, the random custom page ID is generated in the range [0..5], which does not match the resource pack. To avoid missing textures, the range has been updated to [1..6].

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-actions

Copy link
Copy Markdown
Contributor

Test results

216 files  216 suites   1m 46s ⏱️
253 tests 248 ✅  5 💤 0 ❌
762 runs  747 ✅ 15 💤 0 ❌

Results for commit 928f27b.

@theEvilReaper
theEvilReaper merged commit 2ee7c8c into main Aug 11, 2026
8 checks passed
@theEvilReaper
theEvilReaper deleted the fix/customPage branch August 11, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant