Repository navigation
Conversation
The downloader writes the pre-contract reference layout (organisms/<common name>/, indexes/<tool>/<name>, dataset_registry.json), and some of its URLs (rat release 112) now 404. The reference tree under /mnt/nas/omnibioai/reference-genomes follows contract v1 instead. main() now exits 2 with a pointer to the contract unless --i-know-this-writes-legacy-layout is passed. --help still works. The existing CLI tests pass the flag; a new test checks that --status, --scaffold, --dry-run and a bare run all refuse before touching the base directory. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ng CLI tests test_download_cli_branches and test_small_remaining_branches call main() directly; give them the flag, and assert the no-selection exit is code 0 so it cannot pass by being refused. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
download_references.pywrites the pre-contract reference layout (organisms/<common name>/,indexes/<tool>/<name>,dataset_registry.json), and some of its URLs (rat release 112) now 404. The reference tree under/mnt/nas/omnibioai/reference-genomesfollows contract v1 (README.md+_schema/there; validatorscripts/reference/validate_reference.pyin omnibioai-ecosystem).main()now refuses with exit code 2 and a pointer to the contract unless--i-know-this-writes-legacy-layoutis passed.--helpstill works.The guard sits at the top of
main(), not at module import, because the test suite imports the module and callsparse_args()/main()directly.Tests
test_reference_main_refuses_without_legacy_flag:--status,--scaffold,--dry-runand a bare run all exit 2, the downloader is never constructed, and the base dir is never created.Local CI
Hosted CI has no budget until 2026-12-01. Full
pytestwith the repo'spytest.ini, offline (docker run --rm --network none) inobai-workbench:8a1967577087, which provides torch, faiss and sentence-transformers. pytest 8.3.3, pytest-cov 5.0.0 and playwright 1.65.1 come from a local wheel cache;hf_xetis uninstalled as in ci.yml.cdf9ef20 new failures. The same 6 fail on both sides in this environment:
test_coverage_gaps.py::test_reindex_empty_batch_skipped_then_index_dimension_mismatchtest_coverage_gaps.py::test_reindex_ntotal_mismatchtest_high_coverage.py::test_reindex_cuda_success_and_validationtest_high_coverage.py::test_reindex_cuda_error_branchestest_high_coverage.py::test_reindex_validation_failurestest_shell_automation.py::test_split_general_corpus_in_temp_copyThe 98% coverage gate fails on both sides here because of those 6. This PR adds no uncovered lines:
download_references.pyis at 100%, the same as main.A first run of this branch found 2 tests I had missed (
test_download_cli_branches,test_small_remaining_branches). The second commit fixes them, and the numbers above are after that fix.🤖 Generated with Claude Code