docs: fix repository structure, add GCP + generic_sif_runner/workflow_runner, coverage - #1
Merged
Merged
Conversation
…_runner, coverage - Repository Structure was missing two real files (omni_tool_runtime/contract.py, run.py) and two of the three real tools under tools/ (generic_sif_runner/, workflow_runner/) -- echo_test/ was the only one listed. generic_sif_runner in particular is the actual production tool embedded in every ECR/ACR/GCR image (see omnibioai-tes's README), not echo_test -- reframed echo_test as the minimal reference example it actually is. - GCP/GCS support (upload_result.py imports google.cloud.storage) was undocumented -- the Overview's backend list and the results-upload table only mentioned AWS/Azure. Added, alongside the Overview's execution-backend list. - "Kubernetes Job support" is real but means "the same image runs unmodified as a K8s Job container," not Kubernetes-specific code in this repo (there is none) -- clarified rather than left ambiguous. - Testing/Current State claimed "100% coverage". A live `pytest --cov=.` run: 99% (371 tests; two lines in generic_sif_runner/run.py are the only gap). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contract.py/run.pyand two of the three real tools (generic_sif_runner/,workflow_runner/) —generic_sif_runneris actually the production tool embedded in every ECR/ACR/GCR image, notecho_test. Reframedecho_testas the minimal reference it actually is.upload_result.pyimportsgoogle.cloud.storage) was undocumented.Testing
Docs-only change, verified via a live
pytest --cov=.run and direct file inspection.🤖 Generated with Claude Code