Eth send raw transaction conditional - #3523
Open
anegg0 wants to merge 5 commits into
Open
Conversation
… article in sidebars.js and rpc-methods.mdx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New reference page for
eth_sendRawTransactionConditional, plus two diagrams.rpc-methods.mdxnow links to it instead of duplicating a table, andsidebars.jsgains the entry.Document type
Checklist
yarn startoryarn buildAdditional Notes
Also fixes two pre-existing site-wide layout bugs found while testing the page:
VanillaAdmonitiondid not supporttype="caution", so those admonitions rendered with no style, title, or icon on 26 pages. Added the type and a.cautionclass.min-width: auto, so min-content overrode the column'smax-width. Addedmin-width: 0to the article column and the main container.The layout fixes are in shared files (
src/css/custom.scss,src/components/VanillaAdmonition/) and change rendering on every page, not just this one. Verified in the browser at 1600px, 1280px, and 390px: the table of contents returns to the right rail, page-level horizontal scrolling is gone,rpc-methodsrenders identically to before, and full-bleed tables are unaffected.configure-dac.mdx, the worst pre-existing case, is also fixed.Local verification covered
yarn startandyarn typecheck; a fullyarn buildhas not been run, so CI is the gate for link checking.